[Ffmpeg-devel] [BUG] Segfault in h264 decoder on corrupt input

[Matthias Hopf]

Hey,

On Mar 15, 07 20:41:52 +0100, Reinhard Nissl wrote:
> >> I assume, that there is some cleanup code missing before "return -1;".
> > 
> > That could well be, AFAIU the code I couldn't see anything. Also, I've
> > run several tests already, none of them crashed any more.
> 
> Well, just blame me for replying before trying ;-)

Even worse, *I* stand corrected as well :=]

I don't know what I tested, but apparently my last statement that all
changes are necessary is plain dead wrong.

It finally seems that the first two changes are enough. Actually, just
*not* setting s->picture_structure any more is enough, because the
frames are now handled like all other progressive frames.

Still I wouldn't hold my breath, that this fixes all issues. I haven't
come across any more yet, though.

> Actually, neither ffplay nor mplayer crash now, but it looks like we run
> out of buffers due to "return -1".

As the number of dropped frames differ with my patch and "half my
patch", you might want to try again with the first two changes.

So I suggest applying the attached patch only.

Thanks

Matthias

-- 
Matthias Hopf <mhopf at suse.de>      __        __   __
Maxfeldstr. 5 / 90409 Nuernberg   (_   | |  (_   |__          mat at mshopf.de
Phone +49-911-74053-715           __)  |_|  __)  |__  R & D   www.mshopf.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mencoder_h264_paff_crash.diff
Type: text/x-patch
Size: 1253 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070316/18963997/attachment.bin>