[Ffmpeg-devel] Re: [PATCH] Fix compilation when using --disable-opts

[Ramiro Polla]

Hello,

Panagiotis Issaris escreveu:
> Hi Ramiro,
>
> Ramiro Polla schreef:
>   
>> M?ns Rullg?rd escreveu:
>>     
>>> Panagiotis Issaris said:
>>>       
>>>> M?ns Rullg?rd schreef:
>>>>         
>>>>> Diego Biurrun said:
>>>>>           
>>>>>> On Thu, Mar 15, 2007 at 05:58:35PM +0100, Panagiotis Issaris wrote:
>>>>>>        
>>>>>>             
>>>>>>> The attached patch fixes compilation when using the --disable-opts
>>>>>>> parameter. This to help those interested in using a debugger to debug
>>>>>>> FFmpeg.
>>>>>>>           
>>>>>>>               
>>>>>> Looks good.
>>>>>>         
>>>>>>             
>>>>> No, the configure changes lack indentation.
>>>>>       
>>>>>           
>>>> Like this?
>>>>     
>>>>         
>>> Yes.  A couple of things though: won't this leave a core dump behind
>>> if the ebp
>>> test fails?
>>>       
>> This is the same doubt I had for the configure part in [1]. On Windows
>> XP, crashes issue a dialog box (and so configure has to wait). Of course
>> you won't decide if it's ok to crash a program on configure just because
>> of Windows users, but it would be nice to just put a warning before
>> running the tests: "This configure script might crash and generate a
>> core dump" (or something similar).
>>     
> I have to confess that I have no idea on how to solve this on Windows
> :-( But, note that without the patch --disable-opts would just fail to
> compile, but now although apparantly while showing a dialog box, it will
> at least compile...
>   

Don't worry. I'm sure making the configure script not crash on Windows 
is not a high priority for FFmpeg =).
A conditional warning is enough.

> With friendly regards,
> Takis
>
> PS: Luckily it is "just" a dialog box and not a blue screen ;)
>   
Hmm... I didn't see how it behaves in Win 98 or 95 yet =)

Ramiro Polla