[Ffmpeg-devel] Re: ffmpeg build fixes

[Stanislav Brabec]

Diego Biurrun wrote:
> On Thu, Mar 22, 2007 at 11:13:53AM +0100, Stanislav Brabec wrote:
> > Diego Biurrun wrote:
> > 
> > >> ffmpeg.redefined.patch: Fixed lots of repeated compiler warnings.
> > >
> > >What exactly is this supposed to fix?  I get no warnings related to this
> > >code in FFmpeg ...
> > 
> > I see 976 warnings like these:
> > internal.h:252:1: warning: "sprintf" redefined
> > In file included from /usr/include/stdio.h:838,
> >                  from common.h:36,
> >                  from mathematics.c:26:
> > /usr/include/bits/stdio2.h:30:1: warning: this is the location of the previous definition
> 
> I cannot reproduce it.  Compiling which file?  Which compiler etc?

glibc-2.5
gcc (GCC) 4.1.3 20070302 (prerelease) (SUSE Linux)
CFLAGS used: -O2 -fmessage-length=0 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -g -I/usr/include/gsm -fno-strict-aliasing

/usr/include/bits/stdio2.h:
#define sprintf(str, ...) \
  __builtin___sprintf_chk (str, __USE_FORTIFY_LEVEL - 1, __bos (str), \
                           __VA_ARGS__)


> > And I forgot to write another issue:
> > Some distributions package libgsm includes to /usr/include/gsm. It would
> > be nice to check this directory, too.
> 
> Pass --extra-cflags=/usr/include/gsm to configure.

Yes, it is a simple work-around, but it would be nice to check there by
default.

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec at suse.cz
Lihovarsk? 1060/12                            tel: +420 284 028 966
190 00 Praha 9                                fax: +420 284 028 951
Czech Republic                                http://www.suse.cz/