[Ffmpeg-devel] Re: Bethsoft VID demuxer and decoder

[Rich Felker]

On Tue, Mar 27, 2007 at 11:13:37PM +0200, Michael Niedermayer wrote:
> [...]
> > +    static int is_finished;                         // if terminating block is reached, don't need to read junk afterwards
> 
> non constant static variables break thread safety

Usually it's not just a matter of threads but of multiple decoder
instances in general.

> [...]
> > +        case FIRST_AUDIO_BLOCK: av_log(s, AV_LOG_VERBOSE, "first audio block.\n"); exit(0);
> > +        case AUDIO_BLOCK: av_log(s, AV_LOG_VERBOSE, "audio block.\n"); exit(0);
> 
> calling exit() in a demuxer is not ok

Maybe handle exit like printf, etc.? :)

Rich