[Ffmpeg-devel] [PATCH] cs-test Darwin host issues

[Michael Niedermayer]

Hi

On Thu, Mar 29, 2007 at 08:51:08AM -0400, Marc Hoffman wrote:
Content-Description: message body text
> Michael Niedermayer writes:
>  > Hi
>  > 
>  > On Thu, Mar 29, 2007 at 08:19:19AM -0400, Marc Hoffman wrote:
>  > Content-Description: message body text
>  > > 
>  > > 1. Darwin doesn't have a malloc.h header file so I have wrapped that with __APPLE__
>  > >    actually it shouldn't even be used, considering malloc is defined as please_use_av_malloc.
>  > > 2. malloc is defined as av_malloc not malloc.
>  > 
>  > putting #ifdef ANY_OS into c files is unacceptable
>  > 
> 
> No Problem the original code breaks your assertion because it was
> originally __APPLE_CC__ would you rather __APPLE_CC__ or what is your
> suggestion for solving for this particular problem.
> 
> I guess the best way to go about this is as follows:
> 
> remove malloc.h inclusion its not needed because it redefined by other
> 
> headers to please use blah blah.
> 
> The only issue remains is that Apple doesn't include memalign memory
> allocator so the module should just use av_malloc instead consistently.
> 
> 
> The only issue I see with this is that memory was aligned to 2^7 and
> now its aligned to a radix of 2^4. Your call I'm just the messenger.

patch looks ok assuming there are no missmatching free() calls after it

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070329/a9d6cd82/attachment.pgp>