[Ffmpeg-devel] [PATCH] THP Demuxer (Summer of Code qualification task)

[Michael Niedermayer]

Hi

On Fri, Mar 30, 2007 at 11:14:24AM +0200, Baptiste Coudurier wrote:
> Hi
> 
> Marco Gerards wrote:
> > Index: libavcodec/avcodec.h
> > ===================================================================
> > --- libavcodec/avcodec.h	(revision 8540)
> > +++ libavcodec/avcodec.h	(working copy)
> > @@ -248,6 +248,7 @@
> >      CODEC_ID_MUSEPACK7,
> >      CODEC_ID_MLP,
> >      CODEC_ID_GSM_MS, /* As found in WAV */
> > +    CODEC_ID_THP,
> 
> Put it at the end of "video" codec ids.
> 
> >      /* subtitle codecs */
> >      CODEC_ID_DVD_SUBTITLE= 0x17000,
> > @@ -255,6 +256,7 @@
> >  
> >      CODEC_ID_MPEG2TS= 0x20000, /* _FAKE_ codec to indicate a raw MPEG2 transport
> >                           stream (only used by libavformat) */
> > +
> >  };
> 
> cosmetics.

nice review, the patch looks pretty good except these 2 points ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070330/ac19ae3b/attachment.pgp>