[Ffmpeg-devel] [PATCH] THP Demuxer (Summer of Code qualification task)

[Michael Niedermayer]

Hi

On Fri, Mar 30, 2007 at 02:14:41PM +0200, Marco Gerards wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> Hi,
> 
> > Hi
> >
> > On Fri, Mar 30, 2007 at 11:14:24AM +0200, Baptiste Coudurier wrote:
> >> Hi
> >> 
> >> Marco Gerards wrote:
> >> > Index: libavcodec/avcodec.h
> >> > ===================================================================
> >> > --- libavcodec/avcodec.h	(revision 8540)
> >> > +++ libavcodec/avcodec.h	(working copy)
> >> > @@ -248,6 +248,7 @@
> >> >      CODEC_ID_MUSEPACK7,
> >> >      CODEC_ID_MLP,
> >> >      CODEC_ID_GSM_MS, /* As found in WAV */
> >> > +    CODEC_ID_THP,
> >> 
> >> Put it at the end of "video" codec ids.
> 
> Done.  Now for real. :-)
> 
> >> >      /* subtitle codecs */
> >> >      CODEC_ID_DVD_SUBTITLE= 0x17000,
> >> > @@ -255,6 +256,7 @@
> >> >  
> >> >      CODEC_ID_MPEG2TS= 0x20000, /* _FAKE_ codec to indicate a raw MPEG2 transport
> >> >                           stream (only used by libavformat) */
> >> > +
> >> >  };
> >> 
> >> cosmetics.
> 
> I removed this line.
> 
> > nice review, the patch looks pretty good except these 2 points ...
> 
> Thanks a lot, both of you, for your patience and the review.  I know
> this is a time consuming process.
> 
> In this patch I made a small change.  There was a problem with files
> that have an audio stream.  One header was 32 bits bigger, I just
> added code to skip these bits for now.
> 
> Do you want to wait with applying this patch until I implemented audio
> support, or will you apply it now?  In case you apply it now, I will
> send the patch for audio support somewhere next week.

patch looks ok

the audio patch should be against svn + current patch (no matter if it
actually has been applied or not)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070330/02ee1970/attachment.pgp>