[FFmpeg-devel] [PATCH] add dca and vc1 objects to Makefile when parsers are enabled

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Thu, May 03, 2007 at 11:54:56AM +0200, Diego Biurrun wrote:
>   
>> On Thu, May 03, 2007 at 09:28:57AM +0200, Benoit Fouet wrote:
>>     
>>> seen on ffmpeg user mailing list
>>> when disabling en/decoders, those two objects are not built even though
>>> they are needed to parse
>>>       
>> The patch is OK, but I think it would be better to put the dca and vc1
>> parser code in parser.c along with the rest of the parsers.  The parser
>> code is a very small part of both decoders.
>>     
>
> _all_ parsers should be put in seperate files. putting them in parser.c
> is an extreemly ugly hack and while i agreed for ac3 as noone was willing
> to solve that properly i will NOT agree to move the other parsers to the
> wrong file too!
>
>   
so the correct solution is to create, for instance:
dca_parser.c and vc1_parser.c ?

Ben

-- 
Purple Labs S.A.
www.purplelabs.com