[FFmpeg-devel] [PATCH] configure: x11grab + ld --as-needed

[Pavlov Konstantin]

On Thu, May 03, 2007 at 01:46:47PM +0200, Diego Biurrun wrote:
> On Wed, May 02, 2007 at 05:18:54PM +0400, Pavlov Konstantin wrote:
> > 
> > While trying to enable x11grab, i found out a small error in configure
> > system checks:
> > check_cmd places -lfoo before object file, so it fails when you invoke ld
> > with --as-needed option.
> > 
> > Attached patch fixes it and also adds configure output whether x11grab is
> > enabled or not.
> 
> You're mixing separate issues in a single patch.  That's a nono.

Got it, thanks.

> > --- a/configure
> > +++ b/configure
> > @@ -1729,7 +1729,8 @@ check_header X11/Xlib.h                 &&
> >  check_header X11/extensions/XShm.h      &&
> >  check_func XOpenDisplay -lX11           &&
> >  check_func XShmCreateImage -lX11 -lXext &&
> > -add_extralibs -lX11 -lXext              ||
> > +add_extralibs -lX11 -lXext              &&
> > +enable x11_grab                         ||
> >  disable x11_grab_device_demuxer
> 
> Looks wrong, what's the problem you're trying to address there?

Only adding x11_grab variable to be used in configure output.

> > @@ -1833,6 +1834,7 @@ echo "static                    $static"
> >  echo "shared                    $shared"
> >  echo "postprocessing support    $pp"
> >  echo "software scaler enabled   $swscaler"
> > +echo "x11 grabbing enabled      $x11_grab"
> >  echo "video hooking             $vhook"
> 
> I don't really like this.  We have a list of things that we print info
> about.  You could argue that it's arbitrary, adding things here and
> there is not going to help (much).

I think it's actually a good idea to print out useful info about configure
results. Especially when it comes to something i explicitly --enable.
Could be done with $x11_grab_device_demuxer though.

-- 
Why am I so soft in the middle when the rest of my life is so hard?
		-- Paul Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070503/6f324e28/attachment.pgp>