[FFmpeg-devel] [PATCH] move mpeg4video_parser in it's own file

Diego Biurrun diego
Sat May 5 18:46:14 CEST 2007


On Sat, May 05, 2007 at 06:30:02PM +0200, Aurelien Jacobs wrote:
> 
> Here is a patch to move mpeg4video_parser into it's own .c file.
> Oviously, mpeg4video_parser.c is a svn cp of parser.c.
> Ok to commit ?
> 
> --- libavcodec/mpeg4video_parser.c	(revision 8895)
> +++ libavcodec/mpeg4video_parser.c	(working copy)
> @@ -19,287 +19,12 @@
>  #include "avcodec.h"
>  #include "mpegvideo.h"
> -#include "mpegaudio.h"
>  #include "parser.h"

You don't need all those headers, just parser.h and dsputil.h is
probably enough.

That parser.h depends on dsputil.h being included beforehand is an
uglyness that should be fixed.  IMO headers should directly include
everything they need.

Diego




More information about the ffmpeg-devel mailing list