[FFmpeg-devel] [PATCH] make libavcodec use bytestream functions

Ramiro Ribeiro Polla ramiro
Thu May 10 16:38:45 CEST 2007


M?ns Rullg?rd wrote:
> Jindrich Makovicka wrote:
>   
>> On 5/10/07, Jindrich Makovicka <makovick at gmail.com> wrote:
>>     
>>> On 5/10/07, M?ns Rullg?rd <mans at mansr.com> wrote:
>>>       
>>>> Jindrich Makovicka <makovick at gmail.com> writes:
>>>>         
>>>>> intreadwrite.h needs fixing to compile here.
>>>>>           
>>>> OK.
>>>>
>>>> Out of interest, what compiler are you using, and what is the error
>>>> message?
>>>>         
>>> i am away from the machine now, but it's gcc from Debian Sid (probably
>>> 4.1.2) complaining about the semicolon after the closing brace.
>>>       
>> more precisely, it complained about this piece of code:
>>
>>         if (le) AV_WL16(*dst, v);
>>         else    AV_WB16(*dst, v);
>>     
>
> Ah, that explains it.  That bit is invalid C with the braces as they are now.
> Where is that code?

Should I fix this in pcm.c with attached patch or intreadwrite.h?

> It smells like someone made a change without even
> building the code first

Nice way to start my svn account... =(
It builds with HAVE_FAST_UNALIGNED. Too bad I didn't test this on arm 
yesterday.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch1.patch
Type: text/x-patch
Size: 470 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070510/a5411f53/attachment.bin>



More information about the ffmpeg-devel mailing list