[FFmpeg-devel] PATCH BlackFin yuv2rgb color space conversion

[Michael Niedermayer]

Hi

On Thu, May 10, 2007 at 08:03:07AM -0400, Marc Hoffman wrote:
Content-Description: message body text
> Michael Niedermayer writes:
>  > Hi
>  > 
>  > On Wed, May 09, 2007 at 09:29:57PM -0400, Marc Hoffman wrote:
>  > > Michael Niedermayer writes:
>  > >  > Hi
>  > >  > 
>  > >  > On Wed, May 09, 2007 at 08:25:19PM -0400, Marc Hoffman wrote:
>  > >  > > Michael Niedermayer writes:
>  > >  > >  > Hi
>  > >  > >  > 
>  > >  > >  > On Tue, May 08, 2007 at 08:46:32PM -0400, Marc Hoffman wrote:
>  > >  > >  > > 
>  > >  > >  > > Blackfin optimized YUV420 to RGB CSC Color Space Converters.
>  > >  > >  > > 
>  > >  > >  > > This patch includes YUV2 -> RGB BGR for 565, 555 and 888 a.k.a. 24bit  
>  > >  > >  > > color.
>  > >  > >  > > 
>  > >  > >  > > Performance gain compared against -O3:
>  > >  > >  > > 
>  > >  > >  > > 2779809/1484290 187.28%
>  > >  > >  > > 
>  > >  > >  > > which normalized translates to ~33c/pel for the reference C vs ~17.5
>  > >  > >  > > c/pel for this optimized implementation.
>  > >  > >  > > 
>  > >  > >  > > Please review again, I hope I got everyones points if I didn't I'm  
>  > >  > >  > > sorry but there was a lot of feedback in the first round.
>  > >  > >  > 
>  > iam fine with either
> 
> ok -- thanks for your rigorous review.
> Thanks

looks ok (though ive not reviewd the actual asm as my bfin knowledge is too
little)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070510/fbcc1d34/attachment.pgp>