[FFmpeg-devel] [PATCH] Split H.261into separate encoder and decoder

[Aurelien Jacobs]

On Mon, 21 May 2007 14:33:57 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Mon, May 21, 2007 at 01:47:06PM +0200, Panagiotis Issaris wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Hi,
> > 
> > The attached patch splits the h261.c file into separate files for the
> > encoder, decoder and common stuff.
> > 
> > The patch shows differences after three svn copies:
> > 
> >  Makefile  |    4
> >  h261.c    |  942
> > - --------------------------------------------------------------
> >  h261.h    |   45 ++
> >  h261dec.c |  355 -----------------------
> >  h261enc.c |  671 --------------------------------------------
> >  5 files changed, 65 insertions(+), 1952 deletions(-)
> 
> looks ok

There is at least one thing which should be changed:

> -    MPV_common_end(s);
> -    return 0;
> -}
> -
>  #ifdef CONFIG_ENCODERS
>  AVCodec h261_encoder = {
>      "h261",
> @@ -978,14 +334,3 @@
>  };
>  #endif
>  
> -AVCodec h261_decoder = {
> -    "h261",

The #ifdef CONFIG_ENCODERS is not useful anymore.

Also another remarks:

> --- libavcodec/Makefile	(revision 9088)
> +++ libavcodec/Makefile	(working copy)
> @@ -83,8 +83,8 @@
>  OBJS-$(CONFIG_FRAPS_DECODER)           += fraps.o
>  OBJS-$(CONFIG_GIF_DECODER)             += gifdec.o lzw.o
>  OBJS-$(CONFIG_GIF_ENCODER)             += gif.o
> -OBJS-$(CONFIG_H261_DECODER)            += h261.o
> -OBJS-$(CONFIG_H261_ENCODER)            += h261.o
> +OBJS-$(CONFIG_H261_DECODER)            += h261.o h261dec.o
> +OBJS-$(CONFIG_H261_ENCODER)            += h261.o h261enc.o

I prefer seeing h261.o after h261dec.o and after h261enc.o, but
that's purely cosmetics and only my personnal feeling so that
don't matter much.

I didn't had a deep look at the patch, but it looks mostly ok.

Aurel