[FFmpeg-devel] [PATCH] RoQ video decoder split

[Diego Biurrun]

On Tue, May 29, 2007 at 03:18:04PM +0200, Vitor wrote:
> Benoit Fouet wrote:
> >[...]
> >as no log message was provided, applied with the following one:
> >cosmetics and function rename
> 
> To give sequence to the RoQ encoder inclusion, I'm sending a patch to 
> split roqvideo.c in roqvideo.c/roqvideo.h/roqvideodec.c. Actually, I'm 
> not sure if the way I made the diffs is the preferred one when splitting 
> files.
> 
> --- libavcodec/roqvideo.c	(revision 9147)
> +++ libavcodec/roqvideo.c	(working copy)
> @@ -21,65 +21,15 @@
>  
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <string.h>
> -#include <unistd.h>
> -
>  #include "avcodec.h"
> -#include "bytestream.h"
> -#include "dsputil.h"
> +#include "roqvideo.h"
>  
> --- libavcodec/roqvideo.c	2007-05-28 16:43:28.000000000 +0200
> +++ libavcodec/roqvideodec.c	2007-05-29 14:52:21.000000000 +0200
> @@ -34,250 +34,13 @@
>  #include "avcodec.h"
>  #include "bytestream.h"
>  #include "dsputil.h"
> +#include "roqvideo.h"
>  
> --- libavcodec/roqvideo.c	2007-05-28 16:43:28.000000000 +0200
> +++ libavcodec/roqvideo.h	2007-05-29 14:49:35.000000000 +0200
> @@ -19,20 +19,7 @@
> -
> -#include <stdio.h>
> -#include <stdlib.h>
> -#include <string.h>
> -#include <unistd.h>
> -
>  #include "avcodec.h"
> -#include "bytestream.h"
>  #include "dsputil.h"

I don't think we have a really consistent policy for this, but the
avcodec.h and dsputil.h #includes are redundant in the .c files since
the .h file #includes them already.  In fact the avcodec.h #include can
be left out completely since dsputil.h #includes avcodec.h ...

Diego