[FFmpeg-devel] [PATCH] Doxygenate libavutil/mem.h

Guillaume POIRIER poirierg
Fri Nov 2 20:48:31 CET 2007


Hi,

On 11/2/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Fri, Nov 02, 2007 at 05:11:24PM +0100, Stefano Sabatini wrote:
> > On date Friday 2007-11-02 15:55:25 +0100, Michael Niedermayer encoded:
> > > On Thu, Nov 01, 2007 at 09:25:11PM +0100, Stefano Sabatini wrote:
> > [...]
> > > > Thanks for your review, hope now it is more correct.
> > >
> > > looks ok
> >
> > AAAARGH, where did I left my head!!
> >
> > /**
> > - * Free memory and set the pointer to NULL.
> > - * @param ptr Pointer to the pointer which should be freed.
> > + * Free a memory block which has been allocated with av_malloc(z)() or
> > + * av_realloc() and set to NULL the pointer to it.
> > + * @param ptr Pointer to the pointer to the memory block which should
> > + * be freed.
> > + * @note ptr = NULL is explicitly allowed.
> >     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > wrong since it will cause NULL pointer dereference in the code.
> >
> > New patch and new personal record in subsequently sent wrong patches
> > ;-).
>
> new patch looks ok

Applied

Guillaume
-- 
A soldier will fight long and hard for a bit of colored ribbon.
 -- Napoleon Bonaparte




More information about the ffmpeg-devel mailing list