[FFmpeg-devel] E-AC-3 in FFmpeg

[Michael Niedermayer]

Hi

On Fri, Nov 02, 2007 at 04:31:51PM +0100, Bart?omiej Wo?owiec wrote:
> Hi,
> During GSoC I wrote E-AC-3 decoder. When I have free time I'll try to send 
> next patches to add the code to FFMpeg SVN. I enclose changes which are 
> needed in ac3dec.c to allow using parts of code in eac3dec.c.
> 

please split the (ff_ addition and static removial) from the rest!

also newly added variables should have sensible names, that is
s/flg/flag/
s/bnd/band/


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071103/338aa5f8/attachment.pgp>