[FFmpeg-devel] [PATCH] fix --disable-optimization compilation

[Diego Biurrun]

On Tue, Oct 30, 2007 at 04:06:46AM +0100, Michael Niedermayer wrote:
> On Mon, Oct 29, 2007 at 11:43:14PM +0100, Aurelien Jacobs wrote:
> > 
> > Currently, compilation with no optimization fails because h264_parser.c
> > includes cabac.h, which define a static function which uses
> > last_coeff_flag_offset_8x8. This function is not optimized out, and
> > the var is declared static in h264.c.
> > The obvious solution is to make this var non-static.
> > With the attached patch, compilation with --disable-optimization works
> > for me with gcc-4.2 amd64.
> > Patch OK ?
> 
> well i dunno
> its ugly, the asm doesnt even belong in cabac.* but rather in i386/something

Fixing the uglyness belongs in a separate patch ;)

Moving the ASM is orthogonal to fixing this bug, I vote for this patch.

Diego