[FFmpeg-devel] [PATCH] remove mpeg4aac decoder

[Aurelien Jacobs]

On Sun, 4 Nov 2007 16:31:51 +0100
Diego Biurrun <diego at biurrun.de> wrote:

> On Sun, Nov 04, 2007 at 04:07:24PM +0100, Aurelien Jacobs wrote:
> > 
> > AFAIK *_decoder are not part of public API/ABI.
> > So I see no point in keeping mpeg4aac_decoder conditionned on
> > LIBAVCODEC_VERSION_INT (it's just a duplicate of libfaad_decoder).
> > Attached patch just remove mpeg4aac_decoder.
> > I will apply soon.
> 
> Why are you keeping the entries in avcodec.h?

Because it's required for ABI compatibility (removing it would
change the value of other CODEC_ID_* in the enum).

> > --- libavcodec/libfaad.c	(revision 10924)
> > +++ libavcodec/libfaad.c	(working copy)
> > @@ -325,9 +325,5 @@
> >  
> >  // FIXME - raw AAC files - maybe just one entry will be enough
> >  AAC_CODEC(CODEC_ID_AAC, libfaad);
> > -#if LIBAVCODEC_VERSION_INT < ((52<<16)+(0<<8)+0)
> > -// If it's mp4 file - usually embeded into Qt Mov
> > -AAC_CODEC(CODEC_ID_MPEG4AAC, mpeg4aac);
> > -#endif
> >  
> >  #undef AAC_CODEC
> 
> The comment needs to be updated.  Also, if you remove that entry the
> macro becomes pointless and could be replaced by a standard declaration.

I intended to do exactly this, after the patch is commited.

Aurel