[FFmpeg-devel] [Patch] Alternative OS/2 patch

[Diego Biurrun]

On Mon, Nov 05, 2007 at 08:04:12AM -0800, Dave Yeo wrote:
> On 11/04/07 04:29 pm, Diego Biurrun wrote:
> > On Sun, Nov 04, 2007 at 02:07:54PM -0800, Dave Yeo wrote:
> >> ...
> >> I'm not sure about the use of SLIB_EXTRA_CMD in mingw. It looks like it is 
> >> just appending some more linker flags in which case they could perhaps be 
> >> moved to SHFLAGS and SLIB_EXTRA_CMD moved to prelinking or replaced by 
> >> SLIB_CREATE_DEF_CMD. The SLIB_EXTRA_CMD here could easily be rolled into 
> >> SLIB_CREATE_DEF_CMD as well.
> > 
> > I'm not sure what the lib command does either, but since it is run after
> > installation it cannot add linker flags unless I misunderstand what you
> > mean by "adding linker flags".
> 
> It throws me off by having a cmd that starts with -

That's Makefile syntax.  Errors from commands that start with '-' are
ignored.

> >> --- configure	(revision 10924)
> >> +++ configure	(working copy)
> >> @@ -1210,6 +1212,33 @@
> >> +  os/2)
> >> +    SLIB_CREATE_DEF_CMD="echo LIBRARY \$(FULLNAME) INITINSTANCE TERMINSTANCE > \$(FULLNAME).def; \
> >> +        echo DESCRIPTION '\"\$(SLIBNAME_WITH_VERSION)\"' >> \$(FULLNAME).def; \
> >> +        echo PROTMODE >> \$(FULLNAME).def; \
> >> +        echo CODE PRELOAD MOVEABLE DISCARDABLE >> \$(FULLNAME).def; \
> >> +        echo DATA PRELOAD MOVEABLE MULTIPLE NONSHARED >> \$(FULLNAME).def; \
> >> +        echo EXPORTS >> \$(FULLNAME).def; \
> >> +        emxexp -o \$(OBJS) >> \$(FULLNAME).def"
> > 
> > Try using 'cat << EOF', that should simplify things a lot.
> 
> I've never seen cat used this way and not sure how that would work.

Then it's high time :)

Something like

cat << EOF > filename
some
stuff
EOF

should accomplish the above without all the nasty escaping.

Diego