[FFmpeg-devel] [PATCH 2/6] rmdec.c: ff_rm_parse_frame()

[Aurelien Jacobs]

Ronald S. Bultje wrote:

> Hi,
> 
> On 11/5/07, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > On Mon, Nov 05, 2007 at 12:23:31PM -0800, Ronald S. Bultje wrote:
> > > following up on the previous email, this patch splits out the packet
> > parsing
> > > >from the main function body in rmdec.c into its own function. This is
> > useful
> > > because RTP packets from a realmedia/helix server come into a format
> > packing
> > > that is identical to their packing in the realmedia container format,
> > and
> > > therefore parsing of this packet can be shared between the two.
> >
> > looks ok, also the i -> st->index (which ideally could be seperate ...)
> 
> 
> $attached.
> 
> [...]
> 
> -        pkt->pts= timestamp;
> -        if(flags&2){
> -            pkt->flags |= PKT_FLAG_KEY;
> -            if((seq&0x7F) == 1)
> -                av_add_index_entry(st, pos, timestamp, 0, 0, AVINDEX_KEYFRAME);
> -        }
> +        if(flags&2 && (seq&0x7F) == 1)
> +            av_add_index_entry(st, pos, timestamp, 0, 0, AVINDEX_KEYFRAME);
>      }

Here indentation of av_add_index_entry (and probably also merging of
the 2 if) could be done in a separate commit.

Aurel