[FFmpeg-devel] [PATCH 0/6] split out functions in rmdec.c

[Diego Biurrun]

On Tue, Nov 06, 2007 at 08:39:51AM +0100, Benoit Fouet wrote:
> Michael Niedermayer wrote:
> >
> > On Mon, Nov 05, 2007 at 12:29:40PM -0800, Ronald S. Bultje wrote:
> >   
> >> this patch exports the three functions that I split out before (1-3/6) and
> >> adds a function declaration plus dox comments into rm.h. This allows the
> >> functions to be called from the outside (rtp_rm.c) such that the RTP demuxer
> >> can also read realmedia-formatted packets, i.e. what realmedia/helix servers
> >> return.
> >
> > looks ok
> 
> i'll wait for a "grammar" review before applying this one.

> --- ffmpeg.orig/libavformat/rm.h	2007-11-05 09:55:59.000000000 -0800
> +++ ffmpeg/libavformat/rm.h	2007-11-05 11:56:45.000000000 -0800
> @@ -62,4 +62,44 @@
>  
> +/**
> + * Read the MDPR chunk, which contains stream-specific codec initialization
> + * parameters.
> + *
> + * @param s context containing RMContext, ByteIOContext for stream reading
> + * @param st stream that the MDPR chunk belongs to and where to store the
> + *           parameters read from the chunk into

I'd say "the stream".  Also, you should capitalize properly, same below.

> + * @return 0 on success, errno codes on error
> + */
> +int ff_rm_read_mdpr_codecdata (AVFormatContext *s, AVStream *st);
> +/**

Geez, leave at least a single line of space between function
declarations.

> + * Parse one rm-stream packet from the input bytestream.
> + *
> + * @param s context containing RMContext, ByteIOContext for stream reading
> + * @param st stream to which the packet to be read belongs
> + * @param len length of the packet

packet length

> + * @param pkt packet location to store the parsed packet into

s/into//

> +/**
> + * Retrieve one cached packet from the rm-context. The real contained can

containeR

> + * @param pkt location where to store the packet data into

location to store the packet data

Looks good otherwise.

Diego