[FFmpeg-devel] [PATCH] Musepack SV8 demuxer and decoder
Kostya
kostya.shishkov
Wed Nov 7 07:38:45 CET 2007
On Wed, Nov 07, 2007 at 03:34:19AM +0100, Michael Niedermayer wrote:
> On Mon, Nov 05, 2007 at 09:06:40AM +0200, Kostya wrote:
> > On Mon, Nov 05, 2007 at 02:10:06AM +0100, Michael Niedermayer wrote:
> > > On Sun, Nov 04, 2007 at 04:47:46PM +0200, Kostya wrote:
> > [...]
> > > > > still theres no sense or need for realloc() and memcpy()
> > > >
> > > > Removed
> > >
> > > [...]
> > > > + c->bits = av_realloc(c->bits, buf_size + FF_INPUT_BUFFER_PADDING_SIZE);
> > > > + memcpy(c->bits, buf, buf_size);
> > >
> > > doesnt seem so
> >
> > Oops, removed dependency but forgot to remove actual code.
>
> [...]
> > + c->last_bits_used = bits_used = get_bits_count(gb);
> > + if(c->cur_frame >= c->frames)
> > + c->cur_frame = 0;
> > + *data_size = MPC_FRAME_SIZE * 4;
> > +
> > + return c->cur_frame ? bits_used >> 3 : buf_size;
>
> bits_used seems a little redundant, c->last_bits_used could be used
>
>
> [...]
>
> except that patch looks ok
Applied with noted change.
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
More information about the ffmpeg-devel
mailing list