[FFmpeg-devel] [PATCH] Add the function libavcodec/utils.c:avcodec_type_string

Benoit Fouet benoit.fouet
Thu Nov 8 17:07:35 CET 2007


Stefano Sabatini wrote:
> On date Thursday 2007-11-08 16:43:15 +0100, Diego Biurrun encoded:
>   
>> On Thu, Nov 08, 2007 at 04:18:48PM +0100, Stefano Sabatini wrote:
>>     
>>> suggested log: $subject.
>>>
>>> Well, I know it's stupid, nonetheless I find myself writing this
>>> little function again and again in applications (especially when
>>> I'm trying to do some debugging).
>>>
>>> Also bumps micro version since it adds a function to the external api.
>>>
>>> --- libavcodec/avcodec.h	(revision 10959)
>>> +++ libavcodec/avcodec.h	(working copy)
>>> @@ -2477,6 +2477,18 @@
>>>  
>>> + * @param buf[in] Buffer where to write the string.
>>>       
>> Buffer to write the string into.
>>     
>
> Fixed.
>
>   
>>> + * @param buf_size[in] Size in bytes of \p buf.
>>>       
>> size of \p buf in bytes 
>>     
>
> Fixed.
>  
>   
>>> + * @param codec_type[in] Code of the codec type. Values actually supported are:
>>>       
>> Supported values are
>>
>> Look up the meaning of actually again, it's not what you seem to think.
>>     
>
> From The Collaborative International Dictionary of English v.0.48 [gcide]:
>
>   Actually \Ac"tu*al*ly\, adv.
>      1. Actively. [Obs.] "Neither actually . . . nor passively."
>         --Fuller.
>         [1913 Webster]
>   
>      2. In act or in fact; really; in truth; positively.
>         [1913 Webster]
>
> I meant "now", implicating that the number of supported types might
> increment in future, trying to keep the documentation as generic as
> possible.
>
>   

then why not "currently" ?
to me, actually means "in fact"

-- 
Ben
Purple Labs S.A.
www.purplelabs.com




More information about the ffmpeg-devel mailing list