[FFmpeg-devel] [PATCH] don't include intypes.h directly

[François Revol]

> Aurelien Jacobs <aurel at gnuage.org> writes:
> 
> > Hi,
> >
> > I seem to recall that we had a "policy" of never including 
> > inttypes.h
> > (or stdint.h) directly, but I'm not sure anymore.
> > If I'm right, then I should apply the attached patch. OK ?
> >
> > Aurel
> >
> > Index: libavcodec/intrax8huf.h
> > ===================================================================
> > --- libavcodec/intrax8huf.h	(revision 10987)
> > +++ libavcodec/intrax8huf.h	(working copy)
> > @@ -19,7 +19,7 @@
> >  #ifndef FFMPEG_INTRAX8HUF_H
> >  #define FFMPEG_INTRAX8HUF_H
> >  
> > -#include <inttypes.h>
> > +#include "common.h"
> 
> It looks like all this file needs is stdint.h, in which case that is
> what it should be #including.  Needlessly including common.h will 
> only
> add false dependencies and increase compilation time (not by much, 
> but
> still).
> 
> My personal policy is to explicitly include all headers from which
> features are used, even if some of them might be indirectly included,
> unless this indirect inclusion is documented (e.g. inttypes.h must
> include stdint.h).

Except some platforms don't have stuff in that header but in another 
(like inttypes.h).

Fran?ois.