[FFmpeg-devel] [PATCH] move intrax8 tables from a header to a C file

[Benoit Fouet]

Rich Felker wrote:
> On Sat, Nov 10, 2007 at 02:38:22PM +0100, Aurelien Jacobs wrote:
>   
>> On Sat, 10 Nov 2007 14:05:05 +0100
>> Diego Biurrun <diego at biurrun.de> wrote:
>>
>>     
>>> AFAIU it is preferred to have tables in C files rather than in header
>>> files.
>>>       
>> Prefered by whom ? Not by me.
>> At least not for tables which are not shared between several compilation
>> units.
>>     
>
> A table shared between compilation units still does not belong in a
> header. An extern declaration for it belongs in the header, and the
> table itself belongs in a .c file.

and what if this c file is not compiled, whereas another c file that
uses this file, is compiled ?

>  Otherwise multiple copies of the
> table will exist which is very wasteful.
>   

-- 
Ben