[FFmpeg-devel] [PATCH] Encode Year ID3v2 tag for mp3 files

[Michael Niedermayer]

On Tue, Nov 13, 2007 at 11:51:35PM +0000, M?ns Rullg?rd wrote:
> Patrice Bensoussan <patrice.bensoussan at free.fr> writes:
> 
> > Hello,
> >
> > Here is a patch to encode the year information on mp3 files using
> > ID3v2 tag which was missing.
> > Patrice
> >
> > PS: resubmitting patch from the email address registered on the
> > mailing list, please disregard previous email, sorry about that...
> >
> >
> > Index: libavformat/mp3.c
> > ===================================================================
> > --- libavformat/mp3.c	(revision 11006)
> > +++ libavformat/mp3.c	(working copy)
> > @@ -582,9 +582,12 @@
> >  {
> >      int totlen = 0;
> >      char tracktxt[10];
> > +    char yeartxt[10];
> >
> >      if(s->track)
> >          snprintf(tracktxt, sizeof(tracktxt) - 1, "%d", s->track);
> > +    if(s->year)
> > +        snprintf(yeartxt, sizeof(yeartxt) - 1, "%d", s->year);
> 
> The -1 is unnecessary.

indeed, ive missed that
and the other snprintfs should also be fixed

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071114/69d2e1c0/attachment.pgp>