[FFmpeg-devel] [PATCH] Encode Year ID3v2 tag for mp3 files
Patrice Bensoussan
patrice.bensoussan
Wed Nov 14 01:52:48 CET 2007
On 14 Nov 2007, at 00:28, Michael Niedermayer wrote:
>>>
>>
>> Indeed, I didn't check the man on this one... I assumed the code
>> for track
>> number was right ;-)
>> Here is a new patch including the fix for both.
>
> thats a misunderstanding, there should be 2 patches, 1 for each issue
>
>
> [...]
>> - snprintf(tracktxt, sizeof(tracktxt) - 1, "%d", s->track);
>> + snprintf(tracktxt, sizeof(tracktxt), "%d", s->track);
>> + if(s->year)
>> + snprintf(yeartxt, sizeof(yeartxt), "%d", s->year);
>
> these could be vertically aligned like:
>
> snprintf(tracktxt, sizeof(tracktxt), "%d", s->track);
> if(s->year)
> snprintf( yeartxt, sizeof( yeartxt), "%d", s->year );
>
ok, here is a new patch (removed the fix for track / aligned code as
suggested).
Patrice
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: year_mp3.txt
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071114/d44e4444/attachment.txt>
-------------- next part --------------
More information about the ffmpeg-devel
mailing list