[FFmpeg-devel] [PATCH] flvenc: prefer adpcm_swf after mp3

[Benjamin Larsson]

Alex Beregszaszi wrote:
> On Wed, 2007-11-14 at 17:32 +0100, Benjamin Larsson wrote:
>> Mike Melanson wrote:
>>> Alex Beregszaszi wrote:
>>>   
>>>> Hi,
>>>>
>>>> attached patch changes the default behaviour of flvenc, thus adpcm_swf
>>>> codec will be preferred if there is not any mp3 encoder compiled in.
>>>>     
>>> Wow, this is an interesting issue. On one hand, it will be nice that the
>>> FLV audio encoding will just work right out of the box. OTOH, ADPCM
>>> probably is not what most users want, whether they realize it or not.
>>>
>>>   
>> Well with the trellis options I think the audio quality is fairly ok 
>> compared to the mp3 encoder.
> 
> Btw, any reason why we stick to the 4bit variant?
> 
> It supports 2, 3, 4, 5 bits, the first two sound like crap. Any quality
> improvement in the 5bit over the 4?
> 
> Or should we add support for encoding in all the supported ways? I think
> not.
> 
> --
> Alex
> 

It was easy to support the 4 bit mode because of the existing ima adpcm
code. Same with the trellis feature. Feel free to add the 5 bit mode
though, might sound better then the 4 bit with trellis but I doubt it.

MvH
Benjamin Larsson