[FFmpeg-devel] [PATCH] Fix some defined but not used warnings in snow.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sat, Nov 17, 2007 at 12:40:04PM +0000, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Sat, Nov 17, 2007 at 03:15:05AM +0100, Michael Niedermayer wrote:
>> >> On Sat, Nov 17, 2007 at 12:14:28AM +0100, Diego Biurrun wrote:
>> >> > On Wed, Nov 14, 2007 at 10:54:00AM +0100, Diego Biurrun wrote:
>> >> > > On Sat, Nov 10, 2007 at 06:07:37PM +0100, Diego Biurrun wrote:
>> >> > > > Here are two patches to fix the following warnings in snow.c:
>> >> > > > 
>> >> > > > snow.c:1163: warning: ?spatial_compose53i? defined but not used
>> >> > > > snow.c:1313: warning: ?spatial_compose97i? defined but not used
>> >> > > > snow.c:4142: warning: ?halfpel_interpol? defined but not used
>> >> > > > 
>> >> > > > OK to apply?
>> >> > > 
>> >> > > No word on this?  OK, will apply tomorrow.
>> >> > 
>> >> > Applied.
>> >> 
>> >> how can we identify your system?
>> >> ill add something like
>> >> if diegos system add -w to CFLAGS
>> >
>> > I could try to come up with some build system magic :)
>
> :)
>
>> >
>> > That said, I think most of the other devs prefer to see as many warnings
>> > as possible eliminated.
>> 
>> Indeed.  It makes spotting new, important warnings easier.
>> 
>> Or we could put #ifdef MICHAELNI around unused bits of code like the
>> ones you just removed.
>
> the problem with that is that code which isnt compiled anywhere will
> eventually not compile anywhere anymore
> the halfpel_interpol() will when its finished be faster then the current
> code, having it disabled and broken would throw stones in the way of
> improving snow
> the other code is usefull for debuging ...
>
> why isnt av_unused used for such functions?

Because you didn't explain the above when Diego asked.

-- 
M?ns Rullg?rd
mans at mansr.com