[FFmpeg-devel] [RFC] Split libavformat

[Diego Biurrun]

On Thu, Nov 22, 2007 at 12:01:14PM +0100, Luca Abeni wrote:
> 
> Diego Biurrun wrote:
> >> --- ffmpeg.orig/configure	2007-11-22 08:45:38.000000000 +0100
> >> +++ ffmpeg/configure	2007-11-22 09:53:52.000000000 +0100
> >> @@ -920,9 +920,11 @@
> >>  BSF_LIST=`sed -n 's/^[^#]*BSF.*(.*, *\(.*\)).*/\1_bsf/p' "$source_path/libavcodec/allcodecs.c"`
> >>  MUXER_LIST=`sed -n 's/^[^#]*_MUX.*(.*, *\(.*\)).*/\1_muxer/p' "$source_path/libavformat/allformats.c"`
> >>  DEMUXER_LIST=`sed -n 's/^[^#]*DEMUX.*(.*, *\(.*\)).*/\1_demuxer/p' "$source_path/libavformat/allformats.c"`
> >> +IN_DEV_LIST=`sed -n 's/^[^#]*_IN.*(.*, *\(.*\)).*/\1_indev/p' "$source_path/libavdevice/alldevices.c"`
> >> +OUT_DEV_LIST=`sed -n 's/^[^#]*OUTDEV.*(.*, *\(.*\)).*/\1_outdev/p' "$source_path/libavdevice/alldevices.c"`
> > 
> > INDEV.*
> 
> You mean that I should change _IN.* in INDEV.*? That would require
> to change REGISTER_INOUTDEV() in REGISTER_INDEVOUTDEV() (as it was in
> my previous patch). Otherwise, configure will not see input devices
> registered with REGISTER_INOUTDEV().
> Am I missing some obvious solution? (I am not very skilled with shell
> scripts...). If not, which solution is preferred?

You are right, scratch my comment.

> > Also, it's inconsistent to call it IN_DEV here and INDEV everywhere
> > else.
> 
> Sorry; I'll change IN_DEV in INDEV.
> 
> After these changes, is it ok to commit? Or should I send an updated patch
> for further review?

I don't need to see another patch, I think it is OK to commit.  Please
add a note to the Changelog.

> If it's ok for commit, I have a question: should I create alldevices.c
> with an svn copy from allformats.c (and libavdevice/Makefile with an
> svn cp from libaformat/Makefile), or should I create them as new files?

If in doubt, use svn cp.

Diego