[FFmpeg-devel] Libavnet

[Luca Abeni]

Hi Diego,

Diego Biurrun wrote:
> On Fri, Nov 23, 2007 at 11:01:53AM +0100, Luca Abeni wrote:
>> I attach the latest version of the patch for creating libavnet.
>>
>> --- ffmpeg.orig/configure	2007-11-23 09:13:58.000000000 +0100
>> +++ ffmpeg/configure	2007-11-23 09:49:13.000000000 +0100
> 
> You have missed adding libavnet to DIRS and FILES, this is needed for
> out of tree builds.

Ops... Sorry, I did not know about it. I am fixing the patch locally.


>> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
>> +++ ffmpeg/libavnet/net_support.h	2007-11-23 10:30:13.000000000 +0100
> 
> Maybe net_os_support.h?

Ok


>> @@ -0,0 +1,96 @@
>> +/*
>> + * various utilities for ffmpeg system
> 
> Maybe you can find a slightly more descriptive phrase..

Ok; I'll copy the description from the doxygen entry.


>> + * copyright (c) 2000, 2001, 2002 Fabrice Bellard
> 
> Did Fabrice write this?

As usual, this is hard to tell. I just copied os_support.h, and I did not
think that moving stuff from a file to another deserved a change in the
copyright. svn log and annotate say that the original code was from Fabrice,
then it has been modified by others: you, Michael, mmu_man, Ramiro, and Alex.
But noone claimed the rights on the code. So, once again I do not know what to
do here.

>> +/**
>> + * @file net_support.h
>> + * miscellaneous OS support macros and functions needed to support networking.
> 
> Capitalize.

Ok

>> +/* events & revents */
> 
> What is a revent?

I think it is a "returned event" (poll terminology, I suspect). But again I did
not write this code. I just copied it :).



			Thanks,
				Luca