[FFmpeg-devel] [PATCH] RV30/40 decoder

[Michael Niedermayer]

On Sun, Nov 18, 2007 at 11:11:24AM +0200, Kostya wrote:
> Well, it roughly the same feature-wise as it was,
> I just don't think I will improve it soon, yet
> it is playable (and maybe will attract samples
> and patches, I'm an optimist).

rv30data.h
ok, commit


rv40data.h
> +/**
> + * Luma quantizer values
> + * Second table is used for inter blocks
> + */
> +static const uint8_t rv40_luma_quant[2][32] = {

the name is inconsistant to rv30_luma_dc_quant

except these rv40data.h can be commited


rv34data.h
> +/**
> + * Chroma quantizer values
> + * Second table is used for DC-only blocks
> + */
> +static const uint8_t rv34_chroma_quant[2][32] = {
> + {  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 14, 15,
> +   16, 17, 17, 18, 19, 20, 20, 21, 22, 22, 23, 23, 24, 24, 25, 25 },
> + {  0,  0,  0,  1,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13,
> +   14, 15, 15, 16, 17, 18, 18, 19, 20, 20, 21, 21, 22, 22, 23, 23 }
> +};

the name is inconsistant to rv30_luma_dc_quant
or if its noz just for dc then the comment is wrong

except these rv34data.h can be commited


rv40vlc2.h
ok, commit


rv34vlc.h
> +// INTRA TABLES
> +// BLOCK 0
> +static const uint8_t rv34_table_0_0_0[CBPPAT_VLC_SIZE] =

comment is not doxygen compatible

also the use of names like rv34_table_X_Y_Z instead of tables with
proper names is unacceptable

non table data not yet reviewed

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071123/71eabd58/attachment.pgp>