[FFmpeg-devel] [PATCH] RV30/40 decoder

[Kostya]

On Sat, Nov 24, 2007 at 06:08:54PM +0100, Michael Niedermayer wrote:
> On Sat, Nov 24, 2007 at 04:17:00PM +0100, Reimar D?ffinger wrote:
> > Hello,
> > On Sat, Nov 24, 2007 at 12:58:54PM +0100, Michael Niedermayer wrote:
> > > On Sun, Nov 18, 2007 at 11:11:24AM +0200, Kostya wrote:
> > > > Well, it roughly the same feature-wise as it was,
> > > > I just don't think I will improve it soon, yet
> > > > it is playable (and maybe will attract samples
> > > > and patches, I'm an optimist).
> > > 
> > > more reviewing, also your chances of seeing this applied would improve
> > > if you splited it in maybe 10+ patches!
> > > the problem is every time i look at it i find new issues but its too big
> > > (400k uncompressed) to really review all at once, one inevitably becomes
> > > tired so the quality of the review degrades and many issues are missed
> > > and with the next iteration another subset of the issues is found and
> > > so on ...
> > 
> > Hmm... what do you think about dumping the .h files with the tables into
> > SVN first? This IMO would remove a lot of irritating clutter that is
> > mostly unreviewable from the patch...
> 
> that was my idea though not all tables have passed review yet :)
> the ones which passed can be commited of course, sorry if i havnt
> been clear in my review, i thought it was clear ...

I will commit them (with needed corrections) soon. 
 
> > Also maybe then the patch is small enough so it does need to be
> > compressed, that discourages me immensely from having a look myself
> > (though I'd find it hard to review the code for a proper codec anyway).
> 
> iam also not too happy about the compression but kostya has just a
> modem or isdn or something else ancient IIRC so iam not complaining
> forcing him to upload 400k over a 300bps modem would be too evil ;)
> btw, didnt these modems do lzw compression ...

Well, it's 128/64k ADSL and some problems causing stalls on any SSH/TLS
transmission. IIRC, first message in this thread was being sent for an hour.

> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB