[FFmpeg-devel] [PATCH] move av_crc04C11DB7_update to libavutil

[Måns Rullgård]

Michael Niedermayer wrote:
> On Mon, Oct 29, 2007 at 09:03:39AM +0000, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>>
>> > Hi
>> >
>> > On Sun, Oct 28, 2007 at 10:11:05PM +0100, Baptiste Coudurier wrote:
>> >> Aurelien Jacobs wrote:
>> >> > Michael Niedermayer wrote:
>> >> >
>> >> >
>> >> >>Hi
>> >> >>
>> >> >>On Sun, Oct 28, 2007 at 06:51:19PM +0100, Baptiste Coudurier wrote:
>> >> >>
>> >> >>>Hi
>> >> >>>
>> >> >>>$subject. Needed to avoid code duplication for new ogg muxer.
>> >> >>
>> >> >>libavutil is not supposed to be a place for code common between
>> libavcodec
>> >> >>and libavformat, even less so between 2 libavformat (de)muxers! but
>> rather
>> >> >>a small lib of generally usefull things av_crc04C11DB7_update() is not
>> >> >>usefull outside of libavformat
>> >> >>
>> >> >>so this function should stay in libavformat
>> >>
>> >> Humm, so it ok to add it to aviobuf.c and avio.h for now ?
>> >
>> > yes
>>
>> What sense does it make to have it in aviobuf.c?
>
> reducing code duplication between nut and ogg (de)muxers

What I meant was, what does this have to do with buffered I/O?  Wouldn't
some other file be better suited for this function?

-- 
M?ns Rullg?rd
mans at mansr.com