[FFmpeg-devel] [PATCH] Cleanup for audio grabbing interface and build system

[Diego Biurrun]

On Wed, Sep 05, 2007 at 05:27:42PM -0300, Ramiro Polla wrote:
>
> The audio grabbing interface evolved from a simple audio_device. BeOS audio 
> was then added in a hackish way to make use of the same audio_device format 
> name. For a possible ALSA or any other audio grabbing interface, this 
> should be cleaned.

I like all of this.

> Attached patches do:
>
> audio1.diff
> Separate audio_(de)muxer into oss_(de)muxer and audio_beos_(de)muxer
>
> audio2.diff
> Removes --disable-audio-beos option from configure the same way it was done 
> to v4l(2).
> As a + it also fixes r8006 where Mans introduced a bug to see if there was 
> still anyone using BeOS =). In 6 months, no one seems to have noticed.
>     disabled audio_beos || enable_audio_beos
>                                  ^

:)

> --- libavformat/audio.c	(revision 10415)
> +++ libavformat/audio.c	(working copy)
> @@ -308,7 +308,7 @@
>  
>  #ifdef CONFIG_AUDIO_DEMUXER
> -AVInputFormat audio_demuxer = {
> +AVInputFormat oss_demuxer = {
> @@ -321,7 +321,7 @@
>  
>  #ifdef CONFIG_AUDIO_MUXER
> -AVOutputFormat audio_muxer = {
> +AVOutputFormat oss_muxer = {

Shouldn't you update the #ifdefs here as well?

> --- libavformat/allformats.c	(revision 10415)
> +++ libavformat/allformats.c	(working copy)
> @@ -55,13 +55,13 @@
>      REGISTER_DEMUXER (AVS, avs);
>      REGISTER_DEMUXER (BETHSOFTVID, bethsoftvid);
> +    REGISTER_MUXDEMUX(AUDIO_BEOS, audio_beos);
>      REGISTER_DEMUXER (BKTR, bktr);

Ahem ...

Diego