[FFmpeg-devel] [PATCH] Improve track number decoding for some WMA files

[Patrice Bensoussan]

On 9 Sep 2007, at 15:37, Michael Niedermayer wrote:

> Hi
>
> On Sun, Sep 09, 2007 at 02:51:20PM +0100, Patrice Bensoussan wrote:
>>
>> On 9 Sep 2007, at 14:37, Michael Niedermayer wrote:
>>
>>> Hi
>>>
>>> On Sun, Sep 09, 2007 at 11:33:33AM +0100, Patrice Bensoussan wrote:
>>>> Hello,
>>>>
>>>> A few words about the problem: there are two ways to store the
>>>> track number
>>>> information in WMA files. WM/Track (which is 0-based and is
>>>> deprecated) and
>>>> WM/TrackNumber which is 1-based which is the recommended way to
>>>> store this
>>>> information.
>>>>
>>>> Some WMA files contain both WM/Track and WM/TrackNumber but have an
>>>> incorrect value for WM/Track (1-based instead of 0-based). This
>>>> patch makes
>>>> sure that WM/TrackNumber is used when present and that WM/Track  
>>>> value
>>>> doesn't overwrite the correct track number stored in WM/ 
>>>> TrackNumber.
>>>> Basically WM/Track is ignored if WM/TrackNumber is present.
>>>
>>> does affect  WM/Track string and WM/Track interger? or just one of
>>> them?
>>>
>>
>> Affects WM/Track integer on the file I have. WM/TrackNumber should be
>> the preferred way to read track number which is why I fixed both
>> cases, integer and string. Anything wrong with this?
>
> no iam ok with the patch

fine. anyone to commit?

Patrice