[FFmpeg-devel] [PATCH] Re-add OS/2 support

[KO Myung-Hun]

Hi/2.

The Wanderer wrote:
> KO Myung-Hun wrote:
>
>   
>> Hi/2.
>>
>> Diego Biurrun wrote:
>>     
>
>   
>>> Also, there is a ton of trailing whitespace.
>>>       
>> Although I said in another thread, what is trailing whitespace ? CR ? Or...
>>     
>
> Explicit blank space (i.e., 'space' or 'tab' characters) after the final
> non-blank character on the line. For instance:
>
>   
>> +  os/2*)   
>> +    TMPE=$TMPE".exe"   
>> +    ar="emxomfar -p256"    
>> +    ranlib="echo ignoring ranlib"  
>> +    strip="echo ignoring strip"    
>> +    add_cflags "-Zomf"     
>> +    FFLDFLAGS="-Zomf -Zstack 16384"    
>> +    SHFLAGS="-Zdll -Zomf"  
>> +    FFSERVERLDFLAGS=""     
>> +    LIBPREF=""     
>> +    LIBSUF=".lib"  
>> +    SLIBPREF=""    
>> +    SLIBSUF=".dll"     
>> +    EXESUF=".exe"  
>> +    osextralibs=""     
>> +    pkg_requires=""    
>> +    dv1394="no"    
>> +    ffserver="no"  
>> +    vhook="no"     
>> +    os2="yes"  
>>     
>
> There is significant whitespace after the final quote on each of these
> lines.
>
> Every single added line in the 'ffplay.c' patch except for the #endifs
> also contains trailing whitespace.
>
> Be warned that, although I personally think it doesn't qualify, the
> developers in charge of the FFmpeg SVN repository consider a line
> consisting of nothing but whitespace to have trailing whitespace; at a
> glance, I see three such lines in the patch.
>
>   

Ok, I confirmed. Thanks a lot. ^^

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.4
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr