[FFmpeg-devel] [PATCH] Retrieve APE tags from Monkey Audio file

Kostya kostya.shishkov
Sun Sep 16 17:19:26 CEST 2007


On Sun, Sep 16, 2007 at 04:52:14PM +0200, Benjamin Zores wrote:
> Aurelien Jacobs a ?crit :
> > On Sun, 16 Sep 2007 15:02:34 +0200
> 
> > This big list of if(!strcmp()) looks a bit ugly IMO.
> > Attached updated patch replaces it by a table and a loop.
> > It reduces the object size:
> 
> I like it more than my previous code.
> I've tested it to work as good as the old one.
> 
> Kostya, your opinion about the whole patch ?

Looks good, feel free to commit.
 
> Ben




More information about the ffmpeg-devel mailing list