[FFmpeg-devel] [PATCH] RV30/40 decoder

[Kostya]

On Mon, Sep 17, 2007 at 02:44:13PM +0200, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Sep 17, 2007 at 02:44:20PM +0300, Kostya wrote:
> > On Mon, Sep 17, 2007 at 11:34:17AM +0200, Michael Niedermayer wrote:
> > > Hi
> > > 
> > > On Mon, Sep 17, 2007 at 08:19:50AM +0300, Kostya wrote:
> > [...]
> > > > 
> > > > They are stored in container that way and I have not found a way to determine
> > > > whether current slice is really previous slice tail or not while demuxing.
> > > 
> > > how does mplayers demuxer do it? it does pass complete frames from what
> > > i remember
> > 
> > There is a 'picture number' field in slice header (demuxed, not codec).
> > MPlayer joins them with setting avctx->slice_offset[] but IIRC it still
> > has the problem with slice tails.
> 
> and how does the binary rv decoder handle that?

MPlayer passes similar slice offsets to it and looks like it joins slice end
itself (I discovered this by watching on its internal buffer).
 
> btw, how is rv remuxed in mkv? i dont think its allowed to split slices
> like that in mkv or?
> 
> and do you have a url of such a file with split slices, id like to confirm
> that neither binary nor mkv remuxer nor mplayer can detect the split
> slices

http://samples.mplayerhq.hu/real/VC-RV40/test.rmvb
 
> [...]
> > > [...]
> > > > > [...]
> > > > > > +static void rv40_postprocess(RV40DecContext *r)
> > > > > > +{
> > > > > 
> > > > > unused
> > > > 
> > > > But it should be used and will be used eventually.
> > > 
> > > no, postprocessing does NOT belong in the decoder, a loop filter does but
> > > the name doesnt sound like that
> > > if you want to support rv30/40 postprocessing, write a filter using
> > > the filter layer in soc, it would be interresting to see what effect it
> > > has on h.264 and svq3 ...
> >  
> > Yes, this is a loop filter and it is required to reconstruct frames properly. 
> 
> ok, but then it should not be called postprocess ...

Will be renamed.

> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB