[FFmpeg-devel] [PATCH] avoid using fixed size integers in AC3 code

[Michael Niedermayer]

Hi

On Sun, Sep 23, 2007 at 10:08:30PM -0400, Justin Ruggles wrote:
> $subject
>
> This was discussed already in the E-AC3 patch thread.

yes, now if i would only remember any details ...


>
> Note that dependency checking doesn't seem to catch the changes 
> properly...at least on my system it didn't.  What worked for me was 
> deleting libavformat/raw.o and libavcodec/*ac3*.o before running make.
>
> -Justin

[...]
> @@ -170,11 +170,11 @@
>      int   endmant[AC3_MAX_CHANNELS];        ///< end frequency bin
>      AC3BitAllocParameters bit_alloc_params; ///< bit allocation parameters
>  
> -    int8_t  dexps[AC3_MAX_CHANNELS][256];   ///< decoded exponents
> -    uint8_t bap[AC3_MAX_CHANNELS][256];     ///< bit allocation pointers
> -    int16_t psd[AC3_MAX_CHANNELS][256];     ///< scaled exponents
> -    int16_t bndpsd[AC3_MAX_CHANNELS][50];   ///< interpolated exponents
> -    int16_t mask[AC3_MAX_CHANNELS][50];     ///< masking curve values
> +    int dexps[AC3_MAX_CHANNELS][256];       ///< decoded exponents
> +    int bap[AC3_MAX_CHANNELS][256];         ///< bit allocation pointers
> +    int psd[AC3_MAX_CHANNELS][256];         ///< scaled exponents
> +    int bndpsd[AC3_MAX_CHANNELS][50];       ///< interpolated exponents
> +    int mask[AC3_MAX_CHANNELS][50];         ///< masking curve values

why!? this significantly insreases the size of the context, also it
makes SIMD optimizations using these impossible

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070924/24f91f04/attachment.pgp>