[FFmpeg-devel] [PATCH] Video decoder and demuxer for AMV files

[Diego Biurrun]

On Wed, Sep 26, 2007 at 05:18:27PM +0700, Vladimir Voroshilov wrote:
> 
> Updated patch is attached.
> 
> --- libavcodec/mjpegdec.c	(revision 10560)
> +++ libavcodec/mjpegdec.c	(working copy)
> @@ -662,6 +662,15 @@
> +
> +    if(s->avctx->codec->id==CODEC_ID_AMVVIDEO) {
> +        //Modify pointers for getting upside-down flipped picture

So what is it?  Upside-down, flipped or both?

> --- libavcodec/sp5xdec.c	(revision 10560)
> +++ libavcodec/sp5xdec.c	(working copy)
> @@ -194,3 +198,15 @@
> +
> +AVCodec amvvideo_decoder = {
> +    "amvv",

Why are you calling it amvv and not just amv?

> --- libavcodec/allcodecs.c	(revision 10560)
> +++ libavcodec/allcodecs.c	(working copy)
> @@ -137,6 +137,7 @@
>      REGISTER_DECODER (SP5X, sp5x);
> +    REGISTER_DECODER (AMVVIDEO, amvvideo);
>      REGISTER_ENCDEC  (SVQ1, svq1);

Alphabetical order please.

Diego