[FFmpeg-devel] [PATCH] Video decoder and demuxer for AMV files

[Måns Rullgård]

Vladimir Voroshilov wrote:
> 2007/9/25, Vladimir Voroshilov <voroshil at gmail.com>:
> [...]
>> Fake fourcc code removed.
>> I've also changed CODEC_ID_ADPCM_IMA_WS to CODEC_ID_ADPCM_IMA_AMV,
>> thus Vitor's patch is required too (his codec provides better sound).
>
> Small nit: AMV files are currently reported as "avi", but strictly
> speaking they are broken AVI files.
> Thus, i suggest to add separate AVInputFormat structure especially for
> AMV files (with apropriate name and comment) and
> register it with AVI's config variable (IOW, REGISTER_DEMUXER (AVI, amv))

That's not how it's supposed to be done.  If, and that's an if, a
separate format for AMV is appropriate, it should be registered
conditional to CONFIG_AMV_DEMUXER.  Adding a dependency on the AVI
demuxer in configure will take care of only enabling it when AVI
is enabled.  This was a user can choose to disable only the AMV
demuxer with --disable-demuxer should he wish.

-- 
M?ns Rullg?rd
mans at mansr.com