[FFmpeg-devel] Check on line 2616 h264.c redundant?

[Michael Niedermayer]

Hi

On Thu, Sep 27, 2007 at 11:39:04AM +0200, Panagiotis Issaris wrote:
> Hi,
> 
> On line 2616 of h264.c the following occurs:
> h264_luma_dc_dequant_idct_c(h->mb, s->qscale,
> h->dequant4_coeff[IS_INTRA(mb_type) ? 0:3][s->qscale][0]);
> 
> But, this line appears within a if(IS_INTRA(mb_type)) block. To me it
> seems like it is redundant as the code which is executed between this
> test and line 2616 only contains xchg_mb_border and some prediction code.
> 
> So, is the test redundant or am I missing something?

seems redundant yes ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070927/809ebc43/attachment.pgp>