[FFmpeg-devel] [PATCH] url_split() ipv6 support

[Michael Niedermayer]

Hi

On Thu, Sep 27, 2007 at 03:31:01PM -0400, Gary Corcoran wrote:
> Andreas ?man wrote:
> > Hi,
> > 
> > Gary Corcoran wrote:
> > 
> >> I would suggest that if your parsing does not find an explicit port
> >> number, that _your_ code set the port to the implied '80'.
> > 
> > The default port would have to be an argument to url_split(),
> > because not all protocols use port 80. But perhaps that
> > is obvious...
> 
> Well yes, I meant if the parsing finds http:, set the default to 80.
> For other protocols, set it to their default.  But the user (caller)
> shouldn't have to pre-parse and set up a default every time.  The
> parsing code should contain the defaults and use the proper one
> if there is no explicit port requested...

yes though id say URLProtocol should contain the default port not
url_split() itself otherwise every new URLProtocol would have to change
url_split() ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070927/f79e1c06/attachment.pgp>