[FFmpeg-devel] [PATCH] Demuxer for AMV files

[Vitor Sessak]

Hi

Vladimir Voroshilov wrote:
> Hi, All
> 
> Attached patch implements demuxer for AMV files.
> AMV fourcc tag moved to the end of AVI tags array as suggested by Aurelian.
> 
> Discussion can be found
> in "Video decoder and demuxer for AMV files" thread.
> 
> If patch is ok please apply.
> 
> P.S. AMV video decoder is required for this patch to be applied.

[...]

> +    int width=0, height=0;
> +    int amv_file_format=0;
>  
>      avi->stream_index= -1;
>  
> @@ -276,6 +279,8 @@
>              avi->is_odml = 1;
>              url_fskip(pb, size + (size & 1));
>              break;
> +        case MKTAG('a', 'm', 'v', 'h'):
> +            amv_file_format=1;
>          case MKTAG('a', 'v', 'i', 'h'):
>              /* avi header */
>              /* using frame_period is bad idea */
> @@ -286,8 +291,11 @@
>  
>              url_fskip(pb, 2 * 4);
>              get_le32(pb);
> +            get_le32(pb);
> +            width=get_le32(pb);
> +            height=get_le32(pb);

Sorry for not bring this up before, but wouldn't it be better to call 
these variables "amv_width" and "amv_height" since they are AMV specific?

-Vitor