[FFmpeg-devel] BFI Demuxer

[Luca Barbato]

Sisir Koppaka wrote:
> Hi,
> I got the BFI demuxer without video support(only audio support) working a
> few days ago. I then added the video stream and now the video stream plays
> but not the audio one! I think I may have done some mistake with the stream
> handling.

I'm adding some comments that won't be helpful in sorting out the 
current issue (Eli's one should):

- try to make your code more readable adding empty lines before the 
comments and when it makes sense.

e.g

+    for (i = 0; i < vstream->codec->extradata_size; i++)
+        ((uint8_t *) vstream->codec->extradata)[i] =
+            ((uint8_t *) vstream->codec->extradata)[i] << 2;

+    av_set_pts_info(vstream, 32, 1, bfi->fps);

+    vstream->codec->codec_type = CODEC_TYPE_VIDEO;
+    vstream->codec->codec_id = CODEC_ID_BFI;
+    vstream->codec->width = bfi->width;
+    vstream->codec->height = bfi->height;
+    vstream->codec->pix_fmt = PIX_FMT_PAL8;

another nit

+    if (!bfi->avflag) {
+      move:
+        while (get_byte(pb) != 'I') {

You may put the label aligned to the while.

-- 

Luca Barbato
Gentoo Council Member
Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero