[FFmpeg-devel] [PATCH] [2/??] [3/3] Filter graphs - Parser for a graph description

[Michael Niedermayer]

On Tue, Apr 01, 2008 at 10:49:39PM +0200, Vitor Sessak wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > On Sun, Mar 30, 2008 at 01:50:51PM +0200, Vitor Sessak wrote:
> 
> (...)
> 
> >> static int query_formats(AVFilterGraph *graph)
> >> {
> > 
> > Now i dont think this belongs in the parser code ...
> > There should be IMHO
> > A. code for a filter graph (a single flat filter graph that is a filter graph
> >    is not a filter) If we ever see the need for having filter graphs be
> >    filters this can be added later as a filter easily. Not weirdly
> >    intermingled with everything else.
> > B. the parser
> 
> This function is _not_ passed as a callback to AVFilter.query_formats 
> (but it was some svn revs ago). It is called by the code 
> (avfilter_graph_config_formats()) that tries to set a agreed upon filter 
> format for all filters.

This does NOT belong in the parser! Absolutely nothing related to colorspace
negotation belongs in the parser. No matter in what form.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080401/6dc8a2a5/attachment.pgp>