[FFmpeg-devel] [RFC] LPCM 24 bits support

[Baptiste Coudurier]

Giuliano Pochini wrote:
> On Mon, 07 Apr 2008 14:56:08 +0200
> Baptiste Coudurier <baptiste.coudurier at smartjog.com> wrote:
> 
>> Hi,
>>
>> Giuliano Pochini wrote:
>>> [...]
>>>
>>> +    REGISTER_DECODER (PCM_DVD20, pcm_dvd20);
>>> +    REGISTER_DECODER (PCM_DVD24, pcm_dvd24);
>> IMHO only use one codec id, that is PCM_DVD for > 16 bits, if 16 use
>> CODEC_ID_PCM_S16BE.
> 
> I think we shouldn't overload a decoder to make it decode two different
> formats. One format : one decoder is the cleanest way IMHO and it's how all
> other PCM encoders and decoders are arranged. I don't mind to change it if
> having them merged is better.
> 

Well, ideally only one decoder should exist for all raw variants IMHO, a
decoder for CODEC_ID_RAWAUDIO.
IMHO your patch adds one unecessary CODEC_ID/DECODER in the lib.

DVD formating is unique, and bits per sample is enough to distinguish
the two variants, furthermore, existing demuxers (mplayer by ex) is
using a single decoder for this formating, and could then use ffmpeg
decoder easily.

Mans, Michael ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312