[FFmpeg-devel] [PATCH] BFI demuxer
Sisir Koppaka
sisir.koppaka
Sat Apr 12 14:55:02 CEST 2008
I'll send the new patch soon.
On Sat, Apr 12, 2008 at 6:09 PM, Diego Biurrun <diego at biurrun.de> wrote:
> On Sat, Apr 12, 2008 at 12:27:08PM +0530, Sisir Koppaka wrote:
> > --- bfi.c (revision 0)
> > +++ bfi.c (revision 24)
> > @@ -0,0 +1,210 @@
> > +/*
> > + * Brute Force & Ignorance(BFI) Demuxer
>
> Brute Force & Ignorance (BFI) demuxer
>
> > + * Copyright (c) 2008 Sisir Koppaka.
>
> useless period
>
Deleted
>
> > + /*Loading palette to extradata */
>
> nit: /* Loading palette into extradata */
>
> All of these comments should IMO not use gerunds. Just use
>
> /* Load palette into extradata. */
>
That does save a lot of space...I removed most of the gerunds.
>
> > + url_fseek(pb, 8, SEEK_CUR);
> > + vstream->codec->extradata = av_malloc(768);
> > + vstream->codec->extradata_size = 768;
> > + get_buffer(pb, vstream->codec->extradata,
> > + vstream->codec->extradata_size);
> > +
> > + sample_rate = get_le32(pb);
>
> peculiar spacing..
>
Fixed.
>
> > + /*If all previous chunks were completely read, we try to find a new
> one... */
>
> long line
>
Fixed.
>
> > +AVInputFormat bfi_demuxer = {
> > + "bfi",
> > + "Brute Force & Ignorance",
> > + sizeof(BFIContext),
> > + bfi_probe,
> > + bfi_read_header,
> > + bfi_read_packet,
> > + bfi_read_close,
> > +/*Some more present in libavformat/avformat.h...check out later. */
>
> ?
>
I meant to implement seeking etc....but I've removed the comment now.
>
> Build system part of the patch OK, but you need to update the
> documentation and the Changelog with the new demuxer.
>
The docs folder contains some txt files and some texi files...Can you
please clarify on which particular files to update in the docs folder/main
trunk folder?
-----------------
Sisir Koppaka
More information about the ffmpeg-devel
mailing list