[FFmpeg-devel] [PATCH] wrong time base for audio in AVI

[Reimar Döffinger]

On Sat, Apr 12, 2008 at 08:34:31PM +0200, Michael Niedermayer wrote:
> On Sat, Apr 12, 2008 at 08:06:02PM +0200, Reimar D?ffinger wrote:
> > Maybe, it is unclear to me what exactly is not behaving as intended,
> > that assert in update_initial_durations is based on an awful lot of
> > conditions/assumptions, e.g. that the result of compute_frame_duration
> > fits into a time base. I just assumed that this assumption means that
> > the audio time_base _always_ must be a "multiple" of the sample rate,
> > otherwise I can't see how this should be able to guarantee for e.g.
> > broken files.
> 
> What happens if we just dont call update_initial_durations() if duration==0?

It fixes that file just as well, with no bad effects as far as I can
tell, though pkt->duration == 0 sounds unhealthy to me.
Though if it usually only happens on broken files it should not matter,
I just think the AMV case needs another fix/hack.

Greetings,
Reimar D?ffinger